Echo notifications #1385
Merged
Echo notifications #1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@j-bennet ready for review |
j-bennet
approved these changes
Mar 20, 2024
|
@amacfie Please address the test failures, and then it'll be good to merge. |
|
Whoops, should be good now |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1385 +/- ##
==========================================
+ Coverage 80.04% 80.07% +0.03%
==========================================
Files 25 25
Lines 3067 3072 +5
==========================================
+ Hits 2455 2460 +5
Misses 612 612 ☔ View full report in Codecov by Sentry. |
|
Well done! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An implementation of #1359. If you run
listen channelnameand the channel receives a notification, the next time you run a statement, the notification will be shown (similar to psql).Checklist
changelog.rst.AUTHORSfile (or it's already there).pip install pre-commit && pre-commit install), and ranblackon my code.