-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop python 3.7, add 3.12 #1426
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1426 +/- ##
==========================================
- Coverage 84.15% 79.60% -4.56%
==========================================
Files 21 25 +4
Lines 2720 3030 +310
==========================================
+ Hits 2289 2412 +123
- Misses 431 618 +187
☔ View full report in Codecov by Sentry. |
ha, sorry missed your work on python 3.12. I closed mine: #1428 but seems the tests on 3.12 is unstable, don't know why. from my branch, it sometimes success sometimes fail exactly like yours. (see https://github.com/dbcli/pgcli/pull/1428/commits , no code change in last 2 commit but one failed one succeed.) |
Yes! I'm trying to work around that. May just have to skip it with 3.12. |
816c676
to
38a0798
Compare
38a0798
to
a6dddda
Compare
@laixintao I skipped the failing checks. The build now passes. I still want to find out what's going on, but that can be done in a follow-up PR. What do you think? |
Look pretty good! thanks 👍 |
Description
Blocker:
Checklist
changelog.rst
.AUTHORS
file (or it's already there).pip install pre-commit && pre-commit install
), and ranblack
on my code.