Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runs test on main branch as well. #1429

Merged
merged 2 commits into from
Oct 8, 2023
Merged

runs test on main branch as well. #1429

merged 2 commits into from
Oct 8, 2023

Conversation

laixintao
Copy link
Member

reasons:

  • tests passed on PR branches do not mean they will pass on main branch, for e.g. alice changed A in branch-a, bob changed B in branch-b, both tests passed and no conflict, but after merged to main, a bug occurs.
  • wanna fix the badge in main branch ;D

Description

Checklist

  • I've added this contribution to the changelog.rst.
  • I've added my name to the AUTHORS file (or it's already there).
  • I installed pre-commit hooks (pip install pre-commit && pre-commit install), and ran black on my code.
  • Please squash merge this pull request (uncheck if you'd like us to merge as multiple commits)

reasons:
- tests passed on PR branches do not mean they will pass on main branch,
  for e.g. alice changed A in branch-a, bob changed B in branch-b, both
  tests passed and no conflict, but after merged to main, a bug occurs.
- wanna fix the badge in main branch ;D
@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2023

Codecov Report

Attention: 237 lines in your changes are missing coverage. Please review.

Comparison is base (6884c29) 84.15% compared to head (3545fc9) 79.53%.
Report is 71 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1429      +/-   ##
==========================================
- Coverage   84.15%   79.53%   -4.62%     
==========================================
  Files          21       25       +4     
  Lines        2720     3030     +310     
==========================================
+ Hits         2289     2410     +121     
- Misses        431      620     +189     
Files Coverage Δ
pgcli/__init__.py 100.00% <100.00%> (ø)
pgcli/completion_refresher.py 91.76% <ø> (+1.17%) ⬆️
pgcli/packages/parseutils/__init__.py 100.00% <100.00%> (ø)
pgcli/packages/parseutils/tables.py 97.67% <ø> (ø)
pgcli/packages/prompt_utils.py 70.00% <100.00%> (+5.29%) ⬆️
pgcli/packages/sqlcompletion.py 97.67% <ø> (ø)
pgcli/pgstyle.py 64.00% <ø> (ø)
pgcli/magic.py 0.00% <0.00%> (ø)
pgcli/auth.py 91.30% <91.30%> (ø)
pgcli/key_bindings.py 52.94% <66.66%> (-0.19%) ⬇️
... and 8 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@j-bennet
Copy link
Contributor

j-bennet commented Oct 8, 2023

Thank you @laixintao .

@j-bennet j-bennet merged commit f157f3f into main Oct 8, 2023
7 checks passed
@j-bennet j-bennet deleted the fix-badge branch October 8, 2023 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants