Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependencies: add support for sqlparse 0.5.x #1458

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

kevinmarsh
Copy link
Contributor

@kevinmarsh kevinmarsh commented Apr 15, 2024

Description

sqlparse 0.5.0 was released on 2024-04-13 and contains a security fix for a potential denial of service attack: https://sqlparse.readthedocs.io/en/latest/changes.html#release-0-5-0-apr-13-2024

Other changes mentioned sqlparse's release notes shouldn't break pgcli 🤞 I've run pytest locally (but not behave) so will rely on the GH actions to catch any breaking changes.

[EDIT:] pytest/behave/etc are passing in the GH actions, but seems like there's an unrelated issue with docutils (think maybe rst2html.py was renamed to rst2html?) but running rst2html --halt=warning changelog.rst >/dev/null works locally.

Checklist

  • I've added this contribution to the changelog.rst.
  • I've added my name to the AUTHORS file (or it's already there).
  • I installed pre-commit hooks (pip install pre-commit && pre-commit install), and ran black on my code.
  • Please squash merge this pull request (uncheck if you'd like us to merge as multiple commits)

@j-bennet
Copy link
Contributor

@kevinmarsh Thank you for a PR! I fixed the issue with rst2html that was broken in CI, please pull in main.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.03%. Comparing base (7f05cde) to head (841e061).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1458      +/-   ##
==========================================
- Coverage   80.13%   80.03%   -0.10%     
==========================================
  Files          25       25              
  Lines        3126     3126              
==========================================
- Hits         2505     2502       -3     
- Misses        621      624       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kevinmarsh
Copy link
Contributor Author

@j-bennet I just rebased onto main and all checks have now passed 👍

@j-bennet j-bennet merged commit c6c5f04 into dbcli:main Apr 25, 2024
7 checks passed
@pvacey
Copy link

pvacey commented Apr 30, 2024

When can we expect a new release with this updated dependency?

@j-bennet
Copy link
Contributor

j-bennet commented May 2, 2024

I'll release this weekend.

@j-bennet
Copy link
Contributor

4.1.0 is out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants