Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sisterproject extractor #743

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

datalogism
Copy link
Member

Following the @jlareck template
#719
i finished to develop a multilingual (that need to be configured for new lang)
sister project extractor.

@datalogism
Copy link
Member Author

A question for my reviewers :
This extractor creates triples with owl:sameAs relation. I made maybe a mistake by using this relation because a wiktionary page is not really equivalent to a wikipedia article... What do you think about it ? Must I create a new relation in the DBpedia ontology for each sister project ?

@TallTed
Copy link
Contributor

TallTed commented Nov 23, 2022

owl:sameAs is definitely the wrong predicate, as it describes co-reference — i.e., owl:sameAs says that the subject and object URIs identify the same entity — far beyond the relation you appear to have been trying to describe.

That said, I'm not sure what the relation you were trying to describe actually is. Perhaps you can describe it in English? That will help your readers guide you to an existing predicate that describes that relation, or if necessary, suggest how to handle the lack of such.

@datalogism
Copy link
Member Author

Thank you @TallTed for your feedback,
you totally right a sameAs relationship is not the best way for describing it.
The aim of this extractor is to retrieve the Sister projects links related to a given Wikipedia article, for example the Commons, the Wiktionary, Wikiquotes...
A good practice could be to take example on :

@datalogism
Copy link
Member Author

An other solution could be also to use : skos:related
@jlareck @Vehnem @kurzum, what is your opinion about that ?

@sonarcloud
Copy link

sonarcloud bot commented Dec 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Comment on lines +22 to +23
* Extracted information is represented using properties in the http://xx.dbpedia.org/property/
* namespace (where xx is the language code).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Extracted information is represented using properties in the http://xx.dbpedia.org/property/
* namespace (where xx is the language code).
* Extracted information is represented using properties in the
* <http://xx.dbpedia.org/property/> namespace (where xx is the language code).

* namespace (where xx is the language code).
* The names of the these properties directly reflect the name of the Wikipedia infobox property.
* Property names are not cleaned or merged.
* Property types are not part of a subsumption hierarchy and there is no consistent ontology for the infobox dataset.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Property types are not part of a subsumption hierarchy and there is no consistent ontology for the infobox dataset.
* Property types are not part of a subsumption hierarchy, and there is no consistent ontology for the infobox dataset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants