Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit autoupdate workflow #296

Merged
merged 16 commits into from
Sep 20, 2024
Merged

Add pre-commit autoupdate workflow #296

merged 16 commits into from
Sep 20, 2024

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented Sep 6, 2024

Problem

We moved all linting and formatting dependencies into .pre-commit-config.yml. While this consolidates these tools and isolates the dev environment from these dependencies, it also hides them from dependabot.

Solution

Add a reusable workflow in dbt-labs/actions and call it here. This workflow will:

  • run pre-commit autoupdate
  • run pre-commit run --all-files
  • submit a PR if updates were found

CI will take care of the verification of whether new conflicts were found in the updated pre-commit hooks.

The resulting PR: #297

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development, and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label Sep 6, 2024
Copy link

github-actions bot commented Sep 6, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@mikealfare mikealfare self-assigned this Sep 6, 2024
@mikealfare mikealfare marked this pull request as ready for review September 6, 2024 23:39
@mikealfare mikealfare requested a review from a team as a code owner September 6, 2024 23:39
emmyoop
emmyoop previously approved these changes Sep 9, 2024
Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good pending branch update

.github/workflows/precommit-autoupdate.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@VersusFacit VersusFacit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding a test build.

@mikealfare
Copy link
Contributor Author

I need to wait until the new secrets are added and then this can be merged.

@mikealfare mikealfare merged commit 1f629de into main Sep 20, 2024
11 checks passed
@mikealfare mikealfare deleted the pre-commit-autoupdate branch September 20, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants