mofidy postgres env vars

dbt-labs · Sep 5, 2024 · bcc6980 · bcc6980
1 parent 0253b5d
commit bcc6980
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 17 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -23,6 +23,12 @@ on:
 
 env:
     PYTHON_VERSION: "3.11"
+    POSTGRES_HOST: "postgres_db"
+    POSTGRES_USER: "postgres"
+    DBT_ENV_SECRET_POSTGRES_PASS: "postgres"
+    POSTGRES_PORT: "5432"
+    POSTGRES_DATABASE: "postgres"
+    POSTGRES_SCHEMA: "dbt_codegen_integration_tests_postgres_${{ github.run_number }}"
 
 jobs:
     determine-supported-adapters:
@@ -76,10 +82,10 @@ jobs:
             postgres:
                 image: postgres
                 env:
-                    POSTGRES_USER: ${{ vars.POSTGRES_USER }}
-                    POSTGRES_PASSWORD: ${{ secrets.POSTGRES_PASS }}
-                    POSTGRES_DB: ${{ vars.POSTGRES_DATABASE }}
-                    POSTGRES_HOST: ${{ vars.POSTGRES_HOST }}
+                    POSTGRES_USER: ${{ env.POSTGRES_USER }}
+                    POSTGRES_PASSWORD: ${{ env.DBT_ENV_SECRET_POSTGRES_PASS }}
+                    POSTGRES_DB: ${{ env.POSTGRES_DATABASE }}
+                    POSTGRES_HOST: ${{ env.POSTGRES_HOST }}
                 options: >-
                     --health-cmd pg_isready
                     --health-interval 10s
@@ -116,9 +122,9 @@ jobs:
                   tox -e dbt_integration_${{ matrix.adapter }}
               # postgres runs in the container, so nothing below is an actual secret
               env:
-                  POSTGRES_HOST: postgres_db
-                  POSTGRES_USER: postgres
-                  DBT_ENV_SECRET_POSTGRES_PASS: postgres
-                  POSTGRES_PORT: 5432
-                  POSTGRES_DATABASE: postgres
-                  POSTGRES_SCHEMA: "dbt_codegen_integration_tests_postgres_${{ github.run_number }}"
+                  POSTGRES_HOST: ${{ env.POSTGRES_HOST }}
+                  POSTGRES_USER: ${{ env.POSTGRES_USER }}
+                  DBT_ENV_SECRET_POSTGRES_PASS: ${{ env.DBT_ENV_SECRET_POSTGRES_PASS }}
+                  POSTGRES_PORT: ${{ env.POSTGRES_PORT }}
+                  POSTGRES_DATABASE: ${{ env.POSTGRES_DATABASE }}
+                  POSTGRES_SCHEMA: ${{ env.POSTGRES_SCHEMA }}
diff --git a/integration_tests/README.md b/integration_tests/README.md
@@ -48,15 +48,15 @@ The environment variables you'll need to set for each adapter are:
 
 ```bash
 # Postgres — these are the defaults for the Docker container so actually have values
-export POSTGRES_HOST=localhost
-export POSTGRES_USER=root
-export POSTGRES_PASS=''
-export POSTGRES_PORT=5432
-export POSTGRES_DATABASE=circle_test
+export POSTGRES_TEST_HOST=localhost
+export POSTGRES_TEST_USER=root
+export POSTGRES_TEST_PASS=''
+export POSTGRES_TEST_PORT=5432
+export POSTGRES_TEST_DBNAME=circle_test
 
 # BigQuery
 export BIGQUERY_SERVICE_KEY_PATH=
-export BIGQUERY_PROJECT=
+export BIGQUERY_TEST_DATABASE==
 
 # Redshift
 export REDSHIFT_HOST=
@@ -71,7 +71,7 @@ export SNOWFLAKE_USER=
 export SNOWFLAKE_PASSWORD=
 export SNOWFLAKE_ROLE=
 export SNOWFLAKE_DATABASE=
-export SNOWFLAKE_WAREHOUSE=
+export SNOWFLAKE_WAREHOUSE=s
 ```
 
 ### Setup Postgres or other database targets