Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Changelog #174

Merged
merged 19 commits into from
Jun 4, 2024
Merged

Update Changelog #174

merged 19 commits into from
Jun 4, 2024

Conversation

gwenwindflower
Copy link
Contributor

No description provided.

@pnadolny13
Copy link
Contributor

@gwenwindflower is it possible to get this merged with a release? To have #168 supported without pinning to a git branch 😄 . I'm happy to help with anything needed to get it across the finish line!

@gwenwindflower
Copy link
Contributor Author

gwenwindflower commented May 30, 2024

@pnadolny13 huge apologies! i had some health issues crop up and was out of office for a bit, and it's taking me some time to get fully recalibrated. i'm going to block out time Monday and Tuesday to catch up all the codegen things. Appreciate you!

@pnadolny13
Copy link
Contributor

huge apologies! i had some health issues crop up and was out of office for a bit, and it's taking me some time to get fully recalibrated

No worries! Sorry to hear that, I hope everything is ok. Let me know if theres anything I can help with 😄

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jun 4, 2024
@gwenwindflower
Copy link
Contributor Author

gwenwindflower commented Jun 4, 2024

@pnadolny13 so i've tried a bunch of ways both before i went on medical leave and recently to get testing working for case sensitivity across all the warehouses and it just seems to be technically infeasible right now.

as such, i'm just removing testing and going to ship a beta release of case sensitivity without tests. if that seems to be okay after a month or so we'll just cut that as a regular release and keep going.

dbt-labs/dbt-adapters#178 needs to be fixed in dbt Core to make testing possible for this, which is essentially we need for dbt to preserve case sensitivity in seeds, which it does not right now. at present if you have a CasEd SeEd dbt will default to the warehouse's default casing UPPER or lower, etc. So we're unable to seed the testing data reliably across adapters. C'est la vie, we shall beta it for now and it should be okay.

@dave-connors-3 dave-connors-3 self-requested a review June 4, 2024 16:53
@gwenwindflower gwenwindflower merged commit 171343d into main Jun 4, 2024
5 checks passed
@gwenwindflower gwenwindflower deleted the docs/update-changelog branch June 4, 2024 16:55
@gwenwindflower
Copy link
Contributor Author

@pnadolny13 please try out codegen 0.13.0-b1 and let me know it goes!

@dataders
Copy link

linking dbt-labs/dbt-adapters#178 as what screwed up the integration tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants