Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.4.latest] Drop support for Python 3.8 #2 #938

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

mikealfare
Copy link
Contributor

Backport #931 addition

The python version was specified in .pre-commit-config.yml, which was missed during the backport as this is not the case in newer versions.

@mikealfare mikealfare self-assigned this Oct 23, 2024
@mikealfare mikealfare requested a review from a team as a code owner October 23, 2024 14:38
@cla-bot cla-bot bot added the cla:yes label Oct 23, 2024
@VersusFacit VersusFacit changed the base branch from main to 1.4.latest October 23, 2024 15:42
Copy link
Contributor

@VersusFacit VersusFacit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the base from main. I am paranoid, so PLEASE double check it's right now

@mikealfare
Copy link
Contributor Author

The above tests passed. The failures are due to pytest not finding anything and returning an exit code of 5 instead of 0, which was not handled in the workflows for older versions.

@mikealfare mikealfare merged commit fd090f7 into 1.4.latest Oct 23, 2024
15 of 19 checks passed
@mikealfare mikealfare deleted the backport/1.4.latest/drop-py38-support branch October 23, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants