Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add datadog env vars #690

Merged
merged 2 commits into from
Jul 17, 2023
Merged

add datadog env vars #690

merged 2 commits into from
Jul 17, 2023

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Jul 14, 2023

resolves #8081
docs dbt-labs/docs.getdbt.com/# n/a

Problem

Datadog not ingesting test data for flaky test visibility

Solution

Adds env vars to turn on test visibility in datadog. Datadog docs

Updates the tox command to include the --ddtrace flag only when running in CI.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@emmyoop emmyoop added the Skip Changelog Skips GHA to check for changelog file label Jul 14, 2023
@cla-bot cla-bot bot added the cla:yes label Jul 14, 2023
@emmyoop emmyoop mentioned this pull request Jul 17, 2023
Closed
10 tasks
@emmyoop emmyoop marked this pull request as ready for review July 17, 2023 14:16
@emmyoop emmyoop requested a review from a team as a code owner July 17, 2023 14:16
@emmyoop emmyoop merged commit 12fc7af into main Jul 17, 2023
24 checks passed
@emmyoop emmyoop deleted the er/datadog-env-vars branch July 17, 2023 22:19
emmyoop added a commit that referenced this pull request Jul 18, 2023
@emmyoop @mikealfare
add datadog env vars (#690)
4855dfc 
Co-authored-by: Mike Alfare <[email protected]>
emmyoop added a commit that referenced this pull request Jul 18, 2023
@emmyoop
add datadog env vars (#690)
3a16126 
Co-authored-by: Mike Alfare <[email protected]>
# Conflicts:
#	dev-requirements.txt
emmyoop added a commit that referenced this pull request Jul 18, 2023
@emmyoop
add datadog env vars (#690)
de31de2 
Co-authored-by: Mike Alfare <[email protected]>
# Conflicts:
#	dev-requirements.txt
emmyoop added a commit that referenced this pull request Jul 18, 2023
@emmyoop
add datadog env vars (#690)
d39dc8c 
Co-authored-by: Mike Alfare <[email protected]>
# Conflicts:
#	dev-requirements.txt
emmyoop added a commit that referenced this pull request Jul 18, 2023
@emmyoop
add datadog env vars (#690)
358e42c 
Co-authored-by: Mike Alfare <[email protected]>
# Conflicts:
#	dev-requirements.txt
This was referenced Jul 18, 2023
Merged
Merged
Merged
Merged
Merged
emmyoop added a commit that referenced this pull request Jul 20, 2023
@emmyoop @mikealfare
add datadog env vars (#690) (#697)
e99842f 
Co-authored-by: Mike Alfare <[email protected]>
emmyoop added a commit that referenced this pull request Jul 20, 2023
@emmyoop
add datadog env vars (#690) (#698)
224d948 
Co-authored-by: Mike Alfare <[email protected]>
# Conflicts:
#	dev-requirements.txt
emmyoop added a commit that referenced this pull request Jul 20, 2023
@emmyoop
add datadog env vars (#690) (#696)
3b90275 
Co-authored-by: Mike Alfare <[email protected]>
# Conflicts:
#	dev-requirements.txt
emmyoop added a commit that referenced this pull request Jul 20, 2023
@emmyoop
add datadog env vars (#690) (#695)
ab3e024 
Co-authored-by: Mike Alfare <[email protected]>
# Conflicts:
#	dev-requirements.txt
emmyoop added a commit that referenced this pull request Jul 20, 2023
@emmyoop
add datadog env vars (#690) (#694)
831a1f8 
Co-authored-by: Mike Alfare <[email protected]>
# Conflicts:
#	dev-requirements.txt
philippe-boyd-maxa pushed a commit to maxa-ai/dbt-snowflake that referenced this pull request Nov 27, 2023
@emmyoop @mikealfare @philippe-boyd-maxa
add datadog env vars (dbt-labs#690)
0b558e3 
Co-authored-by: Mike Alfare <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikealfare mikealfare mikealfare approved these changes

@colin-rogers-dbt colin-rogers-dbt Awaiting requested review from colin-rogers-dbt colin-rogers-dbt is a code owner automatically assigned from dbt-labs/adapters

Assignees
No one assigned
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emmyoop @mikealfare