Drop unicode aware regexes #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regex tokens "\s" and "\d" are "unicode friendly" and could match whitespace and digit characters in other encodings than ASCII. The result of including them in our grammar is that we then require regex support for the entirety of unicode, which builds a large table of unicode characters into our binary. Replace \s and \d with their ASCII-only equivalents, [[:space:]] and [[:digit:]]. Note that this does not remove our unicode dependency by itself. Lalrpop 0.19.12 builds in unicode support by default because it doesn't yet expose the correct configuration knobs to users to enable or disable unicode support. Once lalrpop 0.20 is released, then users that don't require unicode support will be able to disable it using a feature. This change moves Cascade to that "users that don't require unicode" group, so that we can take advantage of removing unicode support once Lalrpop exposes the correct knob.
dburgener
force-pushed
the
dburgener/no-unicode
branch
from
c4c7ccc
to
655b592
Compare
|
Rebased and published this. Since 0.1 is delayed, I think it makes sense to take this for 0.1. |
|
Stable clippy has failed for this run: nightly. A maintainer should check the logs. If known good clippy passed, this is non-fatal to the PR. |
matt-sheets
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex tokens "\s" and "\d" are "unicode friendly" and could match whitespace and digit characters in other encodings than ASCII. The result of including them in our grammar is that we then require regex support for the entirety of unicode, which builds a large table of unicode characters into our binary.
Replace \s and \d with their ASCII-only equivalents, [[:space:]] and [[:digit:]].
Note that this does not remove our unicode dependency by itself. Lalrpop 0.19.12 builds in unicode support by default because it doesn't yet expose the correct configuration knobs to users to enable or disable unicode support. Once lalrpop 0.20 is released, then users that don't require unicode support will be able to disable it using a feature. This change moves Cascade to that "users that don't require unicode" group, so that we can take advantage of removing unicode support once Lalrpop exposes the correct knob.