Fix issues reported by nightly version of clippy #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
dburgener
commented
Jul 27, 2023
dburgener
commented
- It is less error prone if explicit PartialOrd implmenentations call cmp() directly rather than reimplementing the same user logic in terms of partial_cmp()
- Don't use into_iter() on a function that takes IntoIterator
* It is less error prone if explicit PartialOrd implmenentations call cmp() directly rather than reimplementing the same user logic in terms of partial_cmp() * Don't use into_iter() on a function that takes IntoIterator
dburgener
force-pushed
the
dburgener/nightly-clippy
branch
from
d7348d9
to
dc1dec9
Compare
matt-sheets
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.