Fix issues with nest association conflicting with regular association #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are three cases here: * function declarations are handled via derive. The existing behavior could be wrong in some cases, such as the presence of noderive * type declarations are illegal inside resources * rules are handled via normal Cascade inheritance mechanisms So the copying is mostly unneeded, and wrong in the noderive case. Additionally, it makes multiple inheritance challenging.
matt-sheets
reviewed
Sep 26, 2023
matt-sheets
reviewed
Sep 27, 2023
parts seperately The motivation here comes from combining similar associations, such as two different nested associations of the same resource from different parents, or a nested combined with an annotated association. We need to treat associations of the same resource as fundamentally the same, but having multiple parents, which are the different specific resources associated. At the time we are setting up association, there is always one resource that has already been added to the TypeMap for each association. For annotated associations, this is an explicitly declared resource of the resource name. For nested ones, the nested declaration declares a "dom.res" resource. When we later process annotations, we don't care whether "res" exists in this case. So we track these "real" resources, and build our annotations based on them.
I don't know. I'm probably reintroducing a bug here, but it passes tests, so *shrug*?
dburgener
force-pushed
the
dburgener/fix-nest-associate
branch
from
5713875
to
25382b6
Compare
matt-sheets
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.