Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiply-add / multiply-sub (MADD / MSUB) operations. Also implemented sub / add wasm versions #89

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

MaxGraey
Copy link
Contributor

No description provided.

@MaxGraey MaxGraey changed the title Add multiply-add operation Add multiply-add (MADD) operation Jul 14, 2020
@MaxGraey MaxGraey changed the title Add multiply-add (MADD) operation Add multiply-add / multiply-sub (MADD / MSUB) operations. Also implemented sub / add wasm versions Jul 14, 2020
@dcodeIO
Copy link
Owner

dcodeIO commented Jul 14, 2020

Given that mul is already performed in Wasm and that add / sub aren't so slow, and given the scope of this package, I'm wondering if extending the API with rather uncommon methods as proposed here is worth it?

@MaxGraey
Copy link
Contributor Author

MaxGraey commented Jul 14, 2020

mul + add pretty common operation which could be speedup by calling only once instead two (which also required unpack same arguments twice). For example. I could remove rest wasm methods like msub, add and sub which added with this PR if you don't see any sense for it.

@dcodeIO
Copy link
Owner

dcodeIO commented Oct 28, 2021

Having a feeling that peak perf isn't the right motivation in context of this library. In practice it still emulates so fusing two ops seems neglectable?

@dcodeIO dcodeIO added the unsure label Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants