retain label for data frames (#2019)

ddsjoberg · Oct 3, 2024 · 928e43a · 928e43a
1 parent c0602c5
commit 928e43a
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/R/tbl_summary.R b/R/tbl_summary.R
@@ -473,7 +473,7 @@ tbl_summary <- function(data,
 
   obs_to_drop <- is.na(data[[by]])
   cli::cli_inform("{.val {sum(obs_to_drop)}} missing rows in the {.val {by}} column have been removed.")
-  data[!obs_to_drop, ]
+  dplyr::filter(data, !obs_to_drop)
 }
 
 .check_stats_available <- function(cards, statistic) {

diff --git a/tests/testthat/test-tbl_summary.R b/tests/testthat/test-tbl_summary.R
@@ -653,3 +653,16 @@ test_that("tbl_summary() edge case of warning condition printing", {
      as_kable()
  )
 })
+
+# addressing issue #2017
+test_that("tbl_summary() data frame column labels are not dropped", {
+  expect_equal(
+    trial |>
+      as.data.frame() |>
+      tbl_summary(by = response, include = age) |>
+      as.data.frame(col_label = FALSE) |>
+      dplyr::pull(label) |>
+      dplyr::first(),
+    "Age"
+  )
+})