Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add digits argument to tbl_hierarchical() #2035

Merged
merged 18 commits into from
Nov 7, 2024
Merged

Conversation

edelarua
Copy link
Collaborator

@edelarua edelarua commented Oct 7, 2024

What changes are proposed in this pull request?

  • Added digits argument to tbl_hierarchical() and tbl_hierarchical_count().
  • Updated statistic argument to tbl_hierarchical() and tbl_ard_hierarchical() to accept formula-list-selector type.

Also removed unused type code.

Closes #2032


Reviewer Checklist (if item does not apply, mark is as complete)

  • PR branch has pulled the most recent updates from main branch.
  • If a bug was fixed, a unit test was added.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()
  • usethis::use_spell_check() runs with no spelling errors in documentation
  • All GitHub Action workflows pass with a ✅

When the branch is ready to be merged into master:

  • Update NEWS.md with the changes from this pull request under the heading "# gtsummary (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • Increment the version number using usethis::use_version(which = "dev")
  • Run usethis::use_spell_check() again
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge".

@ddsjoberg
Copy link
Owner

Everything looks great! Can we make two changes? Make the statistic and digits argument accept the list-formula notation, with defaults statistic = ~"{n} ({p})", digits = NULL (or whatever makes the most sense)

@edelarua
Copy link
Collaborator Author

edelarua commented Nov 6, 2024

@ddsjoberg this is updated now!

@ddsjoberg
Copy link
Owner

THank you @edelarua !!

@ddsjoberg ddsjoberg merged commit 4f65cdd into main Nov 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add digits argument to tbl_hierarchical()
2 participants