Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ZstdCompressor to S3 Plugin and Fix Tests According to Maintainer's Feedback #2

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Add ZstdCompressor to S3 Plugin and Fix Tests According to Maintainer's Feedback #2

merged 3 commits into from
Oct 25, 2024

Commits on Oct 25, 2024

  1. Remove duplicate ZstdCompressor class as per maintainer's comments 

    Signed-off-by: ddukbg <[email protected]>
    @ddukbg
    ddukbg committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    7f6e51c View commit details
    Browse the repository at this point in the history

  2. Remove ZstdCompressor tests from test_in_s3.rb as per maintainer's co… 

    …mments

Moved ZstdCompressor tests from test_in_s3.rb to test_out_s3.rb as they relate to the out_s3 plugin.

Signed-off-by: ddukbg <[email protected]>
    @ddukbg
    ddukbg committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    6aa84f4 View commit details
    Browse the repository at this point in the history

  3. Add ZstdCompressor test cases to test_out_s3.rb as per maintainer's c… 

    …omments

Added tests for ZstdCompressor to test_out_s3.rb following the maintainer's suggestions.

Signed-off-by: ddukbg <[email protected]>
    @ddukbg
    ddukbg committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    dd3bafb View commit details
    Browse the repository at this point in the history