1656: Work in progress for "typography" and "colors" sections in the style guide. #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my work in progress for assignment 1656.
I worked on implementing the styling from the "Typography" and "Colors" sections of the style guide at https://debugtheme.webflow.io/styles
In the typography.scss file, the font size variables for the heading levels were using rem's and assuming that the browser's base default font size would be 16px. I didn't know if this was true so I changed the units of measurements to px but maybe it should go back to rem in the future — I'm not sure.
Also, how (or when) can we test that these styles are working in the site? I guess a template file has to be calling those classes in the markup? I haven't gone through the Twig parts yet so maybe that's why I can't see anything yet.