Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1656: Work in progress for "typography" and "colors" sections in the style guide. #51

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

jvaughnjohnson
Copy link
Contributor

This is my work in progress for assignment 1656.

I worked on implementing the styling from the "Typography" and "Colors" sections of the style guide at https://debugtheme.webflow.io/styles

In the typography.scss file, the font size variables for the heading levels were using rem's and assuming that the browser's base default font size would be 16px. I didn't know if this was true so I changed the units of measurements to px but maybe it should go back to rem in the future — I'm not sure.

Also, how (or when) can we test that these styles are working in the site? I guess a template file has to be calling those classes in the markup? I haven't gone through the Twig parts yet so maybe that's why I can't see anything yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant