Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

725: Pass block display of existing blog_posts on homepage via twig #138

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

adriennedao
Copy link
Contributor

No description provided.

@adriennedao adriennedao changed the title 725: Pass blog display of existing blog_posts on homepage via twig 725: Pass block display of existing blog_posts on homepage via twig Apr 17, 2018
$variables['blog_block'] = $blog_block;


}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's best to include a blank line at the end of .module files

@@ -76,6 +78,71 @@
}
}

/*** Blog View ***/

h3 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The h3 should be nested under .view-id-blog_posts so that it does not impact other h3's on the website

}

.views-row {
@include make-xs-column(12);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the text nested under .views-row should be indented another level for clarity

@adriennedao
Copy link
Contributor Author

adriennedao commented Apr 18, 2018

Thank you for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants