-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Whitelisted proposers #108
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This contract is a line-for-line copy of LinearERC20VotingExtensible, with the only difference being that each function is marked as `virtual`. It will not be deployed on its own, but used as a base for any downstream strategy that needs to "start with ERC20 token voting" and then tweak parts of it (like whitelisting proposal creation via Hats)
…difies logic for determing if user is allowed to create a proposal based off of if they're wearing a whitelisted hat
mudrila
requested changes
Oct 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have couple requests and questions.
Also, seems like we're lacking deployment script for new strategy
contracts/azorius/LinearERC20VotingWithHatsProposalCreation.sol
Outdated
Show resolved
Hide resolved
contracts/azorius/LinearERC20VotingWithHatsProposalCreation.sol
Outdated
Show resolved
Hide resolved
…erit it in both ERC20 and ERC721 strategies
…tHats_0_1_0 bytecode
mudrila
approved these changes
Oct 10, 2024
DarksightKellar
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lookin' good. Had one observation
Da-Colon
reviewed
Oct 29, 2024
contracts/azorius/LinearERC20VotingWithHatsProposalCreation.sol
Outdated
Show resolved
Hide resolved
Da-Colon
reviewed
Oct 29, 2024
Da-Colon
reviewed
Oct 29, 2024
contracts/azorius/LinearERC20VotingWithHatsProposalCreation.sol
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #107
Closes #110
Implements two new Strategy contracts