Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitelisted proposers #108

Merged
merged 31 commits into from
Nov 6, 2024
Merged

Whitelisted proposers #108

merged 31 commits into from
Nov 6, 2024

Conversation

adamgall
Copy link
Member

@adamgall adamgall commented Oct 2, 2024

Closes #107
Closes #110

Implements two new Strategy contracts

  • Whitelisted Hats able to create proposals with ERC20 token voting
  • Whitelisted Hats able to create proposals with ERC721 token voting

This contract is a line-for-line copy of LinearERC20VotingExtensible, with the only difference being that each function is marked as `virtual`. It will not be deployed on its own, but used as a base for any downstream strategy that needs to "start with ERC20 token voting" and then tweak parts of it (like whitelisting proposal creation via Hats)
…difies logic for determing if user is allowed to create a proposal based off of if they're wearing a whitelisted hat
Copy link
Contributor

@mudrila mudrila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have couple requests and questions.
Also, seems like we're lacking deployment script for new strategy

@adamgall adamgall requested a review from mudrila October 8, 2024 18:27
Copy link
Contributor

@DarksightKellar DarksightKellar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin' good. Had one observation

contracts/azorius/HatsProposalCreationWhitelist.sol Outdated Show resolved Hide resolved
@adamgall adamgall merged commit 04a4df0 into develop Nov 6, 2024
3 checks passed
@adamgall adamgall deleted the whitelisted-proposers branch November 6, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants