Reduce ethers #2415
Merged
Reduce ethers #2415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for decent-interface-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
adamgall
commented
Oct 16, 2024
Comment on lines
+76
to
+81
| if (validateENSName(values.destinationAddress) && publicClient) { | ||
| const ensAddress = await publicClient.getEnsAddress({ name: values.destinationAddress }); | ||
| if (ensAddress === null) { | ||
| throw new Error('Invalid ENS name'); | ||
| } | ||
| destAddress = ensAddress; |
There was a problem hiding this comment.
We were using an ethers instance to do an ENS name lookup here, but there's a similar function on viem's public client
mudrila
approved these changes
Oct 16, 2024
src/components/pages/DAOTreasury/hooks/useTreasuryLidoInteractions.ts
Outdated
Show resolved
Hide resolved
Da-Colon
reviewed
Oct 17, 2024
adamgall
force-pushed
the
reduce-ethers
branch
from
86805b3
to
3ffe821
Compare
|
@Da-Colon please re-review. |
Da-Colon
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce and consolidate the usage of ethers to the bare minimum. Only thing blocking us from removing it entirely is our usage of
@snapshot-labs/snapshot.js, which requires an instance ofethers.Providers.Web3Providerinto itsvotefunction.