Move "isAzorius" from Read Only Values to "governance" state #2511
+33
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for decent-interface-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
adamgall
force-pushed
the
remove-unused-governance-type-enums
branch
from
1392677
to
2a99faa
Compare
adamgall
force-pushed
the
move-isazorius-boolean-to-governance-state
branch
from
c6d58a5
to
1bd2367
Compare
mudrila
approved these changes
Nov 18, 2024
|
Oh wait I forgot to delete more stuff from the |
adamgall
force-pushed
the
move-isazorius-boolean-to-governance-state
branch
from
1bd2367
to
c92578b
Compare
|
Ok that's better |
adamgall
force-pushed
the
move-isazorius-boolean-to-governance-state
branch
from
c92578b
to
c72b7a3
Compare
adamgall
force-pushed
the
move-isazorius-boolean-to-governance-state
branch
from
c72b7a3
to
f87bd90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
daoobject fromreadOnlyValuesstate. Thedaoobject only had one property on it, calledisAzorius. I've moved that over into global state into thegovernancestate, and calculated its value in the reducer action that take thetypeof DAO. if thetypeis one of the Azorius types then this istrue, elsefalse.