Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding JSDocs for all public symbols #823

Merged
merged 3 commits into from
Sep 11, 2024

Conversation

Samuel-Brito19
Copy link
Contributor

@Samuel-Brito19 Samuel-Brito19 commented Sep 7, 2024

Creating good documentation for functions and symbols using JSDocs.

Issue: #815

Copy link
Contributor

github-actions bot commented Sep 7, 2024

Tagging Options

Should a new tag be published when this PR is merged?

  • 👍 for Patch 1.96.9 update
  • 🎉 for Minor 1.97.0 update
  • 🚀 for Major 2.0.0 update

blocks/page.tsx Outdated
@@ -6,6 +6,17 @@ import { createSectionBlock, type SectionModule } from "./section.ts";

export type Page = InstanceOf<typeof page, "#/root/pages">;

/**
* Creates a new Block object for a section within a component or page.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Creates a new Block object for a section within a component or page.
* Defines a Page block. Pages are JSX-based components and can be rendered by any JSX-compliant library like react or preact.

blocks/utils.tsx Outdated
};
/**
* Applies props to a function and returns the result.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Applies props to a function and returns the result.
* Applies the given props to the target block function.

@mcandeia mcandeia merged commit 3e39062 into deco-cx:main Sep 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants