Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work fe1 ljankoschek poptoken mnemonic #1918

Merged
merged 6 commits into from
Jun 30, 2024

Conversation

ljankoschek
Copy link
Contributor

@ljankoschek ljankoschek commented Jun 11, 2024

Implementation of the fe-1 part for the deterministic username generator for a pop token to improve usability. In the roll call attendee list, and the user profile we display both the pop token and the username. In the chirps , the user list and the beneficiary selector we display only the user name now. Issue: #1915

Copy link

Pull reviewers stats

Stats of the last 30 days for popstellar:

User Total reviews Time to review Total comments
K1li4nL
🥇
17
▀▀▀▀
3d 22h 19m
14
▀▀▀
simone-kalbermatter
🥈
4
8h 40m
0
onsriahi14
🥉
4
1d 10h 51m
5
matteosz
4
21h 47m
3
emonnin-epfl
3
8h 20m
8
▀▀
pierluca
2
3d 11h 3m
1
MariemBaccari
2
22h 39m
6
DanielTavaresA
2
9d 21h 46m
▀▀
2
Tyratox
1
44m
0
arnauds5
1
10d 19h 13m
▀▀▀
0
sgueissa
1
6d 11h 44m
▀▀
1
osm-alt
1
25m
0
Kaz-ookid
1
1d 2h 1m
5
⚡️ Pull request stats

@ljankoschek ljankoschek self-assigned this Jun 11, 2024
@ljankoschek ljankoschek added enhancement New feature or request fe1-web labels Jun 11, 2024
@ljankoschek ljankoschek marked this pull request as ready for review June 11, 2024 19:16
@ljankoschek ljankoschek requested a review from a team as a code owner June 11, 2024 19:16
Copy link

sonarcloud bot commented Jun 30, 2024

Copy link

sonarcloud bot commented Jun 30, 2024

Copy link

sonarcloud bot commented Jun 30, 2024

Copy link

sonarcloud bot commented Jun 30, 2024

Copy link
Contributor

@4xiom5 4xiom5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@K1li4nL K1li4nL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blind approval

@K1li4nL K1li4nL added this pull request to the merge queue Jun 30, 2024
Merged via the queue into master with commit 04a581e Jun 30, 2024
17 checks passed
@K1li4nL K1li4nL deleted the work-fe1-ljankoschek-poptoken-mnemonic branch June 30, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fe1-web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants