-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Reported Manage Issues #460
Fix Reported Manage Issues #460
Conversation
WalkthroughThe pull request introduces several modifications across multiple files. Key changes include renaming an attribute in the Changes
Tip New featuresWalkthrough comment now includes:
Notes:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- deepgram/clients/listen/v1/rest/options.py (1 hunks)
- deepgram/clients/manage/v1/response.py (2 hunks)
- examples/manage/usage/main.py (1 hunks)
Files skipped from review due to trivial changes (1)
- examples/manage/usage/main.py
Additional comments not posted (2)
deepgram/clients/listen/v1/rest/options.py (1)
44-44
: Attribute Renaming ApprovedThe renaming of
custom_topics
tocustom_topic
is approved as it aligns with the PR's objectives to clarify usage. Ensure that all references to this attribute in the SDK and the documentation are updated accordingly.Verification successful
Attribute Renaming Verified
The renaming of
custom_topics
tocustom_topic
has been successfully applied throughout the codebase. No occurrences of the old attribute name were found, confirming the update's consistency. Ensure that documentation reflects this change as well.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all references to `custom_topic` are updated. # Test: Search for the old attribute name. Expect: No occurrences. rg --type python -A 5 $'custom_topics'Length of output: 68
Script:
#!/bin/bash # Description: Verify all references to `custom_topic` are updated. # Test: Search for the old attribute name. Expect: No occurrences. rg --type py -A 5 $'custom_topics'Length of output: 33
deepgram/clients/manage/v1/response.py (1)
474-481
: Approval of Changes in Response ClassMaking
details
optional and introducingmessage
as a new optional attribute are good practices that enhance the flexibility and robustness of the API responses. The configuration to excludeNone
values from serialization is also commendable.
1f5b483
to
d0618f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- deepgram/clients/listen/v1/rest/options.py (1 hunks)
- deepgram/clients/manage/v1/response.py (2 hunks)
- examples/manage/usage/main.py (1 hunks)
Files skipped from review due to trivial changes (1)
- examples/manage/usage/main.py
Files skipped from review as they are similar to previous changes (2)
- deepgram/clients/listen/v1/rest/options.py
- deepgram/clients/manage/v1/response.py
Proposed changes
Addresses Issue: #458, #459
Changes:
str
orList[str]
Local testing
make unit-test
is good.Types of changes
What types of changes does your code introduce to the community Python SDK?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
NA
Summary by CodeRabbit
New Features
PrerecordedOptions
class to use a singularcustom_topic
attribute for improved clarity.Response
class, includingmessage
, enhancing response flexibility.Bug Fixes
Details
class to be optional, allowing for more robust handling of data.Style