Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove resource limits on Compose file templates #51

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

bd-g
Copy link
Collaborator

@bd-g bd-g commented Dec 2, 2024

Proposed changes

Resource limits can be an effective way to prevent containers from starving eachother.

However, in a single VM running multiple Deepgram containers (most common use case with Docker), allowing containers to have more ebb and flow in their resource usage can lead to greater performance and easier management.

This also prevents artificially low limits being enforced when these templates are used for more powerful instance types, but users forget to increase the default limits.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update or tests (if none of the other choices apply)
    • Updated best practice on Compose templates

Checklist

  • I have read the CONTRIBUTING doc
  • I have tested my changes in my local self-hosted environment
  • I have added necessary documentation (if appropriate)

@bd-g bd-g requested a review from jkroll-deepgram December 2, 2024 22:46
@bd-g bd-g requested a review from a team as a code owner December 2, 2024 22:46
@jkroll-deepgram
Copy link
Contributor

Makes sense. Do we want to leave it commented-out, or document elsewhere how/when to impose resource limits? Or is that considered outside the scope of what we want to educate here?

@bd-g bd-g merged commit 831fafa into main Dec 3, 2024
2 checks passed
@bd-g bd-g deleted the brent-george/remove-docker-compose-resource-limits branch December 3, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants