Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] alternative NDArray should not be closed in NDScope #3490

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

frankfliu
Copy link
Contributor

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@frankfliu frankfliu requested review from zachgk and a team as code owners October 1, 2024 16:28
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.42%. Comparing base (b6656ed) to head (acc8336).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##             master    #3490       +/-   ##
=============================================
- Coverage     72.52%   58.42%   -14.11%     
+ Complexity     7394     5800     -1594     
=============================================
  Files           672      672               
  Lines         32909    32910        +1     
  Branches       3501     3501               
=============================================
- Hits          23868    19228     -4640     
- Misses         7400    12209     +4809     
+ Partials       1641     1473      -168     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sindhuvahinis sindhuvahinis merged commit e623210 into deepjavalibrary:master Oct 2, 2024
5 checks passed
@frankfliu frankfliu deleted the nd branch October 4, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants