Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] Visualize sam2 output for Sam2ServingTranslator #3494

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

frankfliu
Copy link
Contributor

  • [api] Adds sam2 model to onnxruntime model zoo
  • [api] Standardizes CV output format
  • [api] Visualize sam2 output for Sam2ServingTranslator

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@frankfliu frankfliu requested review from zachgk and a team as code owners October 4, 2024 00:31
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 63.97849% with 67 lines in your changes missing coverage. Please review.

Project coverage is 72.39%. Comparing base (b6656ed) to head (7020502).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../modality/cv/translator/Sam2ServingTranslator.java 8.33% 33 Missing ⚠️
.../ai/djl/modality/cv/translator/Sam2Translator.java 73.91% 14 Missing and 4 partials ⚠️
...pencv/src/main/java/ai/djl/opencv/OpenCVImage.java 0.00% 11 Missing ⚠️
...main/java/ai/djl/onnxruntime/engine/OrtEngine.java 33.33% 1 Missing and 1 partial ⚠️
...ava/ai/djl/modality/cv/output/DetectedObjects.java 66.66% 0 Missing and 1 partial ⚠️
.../modality/cv/translator/Sam2TranslatorFactory.java 75.00% 0 Missing and 1 partial ⚠️
...pi/src/main/java/ai/djl/util/JsonSerializable.java 80.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3494      +/-   ##
============================================
- Coverage     72.52%   72.39%   -0.13%     
- Complexity     7394     7410      +16     
============================================
  Files           672      674       +2     
  Lines         32909    33027     +118     
  Branches       3501     3516      +15     
============================================
+ Hits          23868    23911      +43     
- Misses         7400     7483      +83     
+ Partials       1641     1633       -8     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xyang16 xyang16 merged commit d3c69e2 into deepjavalibrary:master Oct 4, 2024
4 checks passed
@frankfliu frankfliu deleted the serving branch October 4, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants