Skip to content

Commit

Permalink
ci: pin ubuntu to 22.04 (#4213)
Browse files Browse the repository at this point in the history
It seems that GitHub starts to point ubuntu-latest to ubuntu-24.04
(xref: actions/runner-images#10636), which
brings some breaking changes. For example, cuda 11.8 doesn't support the
default compiler in ubuntu-24.04.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Updated build, test, and analysis workflows to run on Ubuntu 22.04,
enhancing compatibility and performance for C++ projects.
  
- **Bug Fixes**
- Corrected indentation in the permissions section of the CodeQL
workflow.

- **Chores**
- Adjusted timeout settings for the CodeQL analysis job based on the
programming language.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
  • Loading branch information
njzjz authored Oct 15, 2024
1 parent a1f8672 commit 6fe8dde
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build_cc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ name: Build C++
jobs:
buildcc:
name: Build C++
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
strategy:
matrix:
include:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/codeql.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ concurrency:
jobs:
analyze:
name: Analyze
runs-on: ${{ (matrix.language == 'swift' && 'macos-latest') || 'ubuntu-latest' }}
runs-on: ${{ (matrix.language == 'swift' && 'macos-latest') || 'ubuntu-22.04' }}
timeout-minutes: ${{ (matrix.language == 'swift' && 120) || 360 }}
permissions:
actions: read
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test_cc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ name: Test C++
jobs:
testcc:
name: Test C++
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
strategy:
matrix:
check_memleak: [true, false]
Expand Down

0 comments on commit 6fe8dde

Please sign in to comment.