Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix recursion error when handling unsupported types #44

Merged
merged 6 commits into from
Dec 13, 2024
Merged

fix recursion error when handling unsupported types #44

merged 6 commits into from
Dec 13, 2024

Conversation

mpangrazzi
Copy link
Contributor

Should fix #43.

Seems like some nested generic types are causing handle_unsupported_types to return RecursionError: maximum recursion depth exceeded.

@mpangrazzi mpangrazzi mentioned this pull request Dec 4, 2024
Closed
@mpangrazzi mpangrazzi requested a review from anakin87 December 4, 2024 16:46
@mpangrazzi
Copy link
Contributor Author

I've iterated on this:

  • rewrite of handle_unsupported_types (simpler + add tests)
  • add a logger
  • add IT tests of deploying sample pipelines using API, check status and /docs route

This should solve both #43 and #47.

anakin87
anakin87 reviewed Dec 11, 2024
View reviewed changes
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with the changes.

Can we make the tests run in the CI?
We can do this in another PR. Ping me if you need help.

tests/test_files/chat_with_website.yaml Show resolved Hide resolved
anakin87
anakin87 approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.

Feel free to merge, but let's work soon on running tests in the CI.

@mpangrazzi mpangrazzi merged commit 1d96419 into main Dec 13, 2024
@mpangrazzi mpangrazzi deleted the fix-recursion-error branch December 13, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anakin87 anakin87 anakin87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RecursionError when using qdrant-haystack 7.0.0 with Hayhooks
2 participants
@mpangrazzi @anakin87