Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: move dynamo docs into new docs page #2093

Merged
merged 2 commits into from
Jan 21, 2024

Conversation

ion-elgreco
Copy link
Collaborator

@ion-elgreco ion-elgreco commented Jan 20, 2024

Description

Adds the dynamo docs into our new docs, within the python write_deltalake I am pointing to the guide since it's quite extensive and only for S3 users.

@rtyler @dispanser

@github-actions github-actions bot added the binding/python Issues for the Python package label Jan 20, 2024
@MrPowers
Copy link
Collaborator

LGTM, but I think we might want to organize this content a bit differently.

Here's the current structure:

  • Usage
    • Writing a table

Here's what you're proposing:

  • Usage
    • Writing
      • Writing to S3 with S3 locking provider

We may want to organize the content as follows:

  • Clouds
    • AWS
      • S3 locking with DynamoDB
      • AWS Lambda
      • AWS Sagemaker
    • Azure
      • Azure functions

@ion-elgreco
Copy link
Collaborator Author

We could reorganize that a bit later, currently I am only moving some docs that landed by accident in the sphinx back in to the current docs.

In terms of terminology, I would say object store probably better and S3 API is also used outside of AWS so maybe best to not to mention AWS specifically here

@MrPowers
Copy link
Collaborator

@ion-elgreco - yea, in general Google doesn't like when pages get moved to new URLs. Perhaps we can add redirects for the links we're breaking? https://github.com/mkdocs/mkdocs-redirects

@ion-elgreco
Copy link
Collaborator Author

ion-elgreco commented Jan 20, 2024

@MrPowers a nice one, let's do that in the next reorganisation of the pages.

Then I'll also write a small example where you write to Azure

Copy link
Collaborator

@MrPowers MrPowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ion-elgreco ion-elgreco merged commit 61ca275 into delta-io:main Jan 21, 2024
23 checks passed
RobinLin666 pushed a commit to RobinLin666/delta-rs that referenced this pull request Feb 2, 2024
# Description
Adds the dynamo docs into our new docs, within the python
write_deltalake I am pointing to the guide since it's quite extensive
and only for S3 users.


@rtyler @dispanser
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/python Issues for the Python package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants