-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: minor fixes to the architecture documentation #2934
Conversation
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
@@ -86,7 +86,7 @@ Create another pandas DataFrame and append it to the Delta table to see how this | |||
|
|||
```python | |||
df = pd.DataFrame({"num": [8, 9], "letter": ["dd", "ee"]}) | |||
write_deltalake(f"{cwd}/tmp/delta-table", df, mode="append") | |||
write_deltalake("tmp/some-table", df, mode="ovewrite") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The snippet of text preceding this mentions appending the dataframe to the table, I am assuming the change in mode
here is in error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, I got to a bit to zealous, this one should be append
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2934 +/- ##
==========================================
- Coverage 72.43% 72.42% -0.01%
==========================================
Files 131 131
Lines 40542 40542
Branches 40542 40542
==========================================
- Hits 29366 29362 -4
+ Misses 9291 9287 -4
- Partials 1885 1893 +8 ☔ View full report in Codecov by Sentry. |
Description
Fix typos and errors in the code of the "architecture" documentation