Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: minor fixes to the architecture documentation #2934

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

0x26res
Copy link

@0x26res 0x26res commented Oct 9, 2024

Description

Fix typos and errors in the code of the "architecture" documentation

@0x26res 0x26res requested a review from MrPowers as a code owner October 9, 2024 12:35
Copy link

github-actions bot commented Oct 9, 2024

ACTION NEEDED

delta-rs follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

@0x26res 0x26res changed the title Minor fixes to the doc docs: Minor fixes to the architecture documentation Oct 9, 2024
@rtyler rtyler changed the title docs: Minor fixes to the architecture documentation docs: minor fixes to the architecture documentation Oct 10, 2024
@@ -86,7 +86,7 @@ Create another pandas DataFrame and append it to the Delta table to see how this

```python
df = pd.DataFrame({"num": [8, 9], "letter": ["dd", "ee"]})
write_deltalake(f"{cwd}/tmp/delta-table", df, mode="append")
write_deltalake("tmp/some-table", df, mode="ovewrite")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The snippet of text preceding this mentions appending the dataframe to the table, I am assuming the change in mode here is in error?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, I got to a bit to zealous, this one should be append.

Copy link
Member

@rtyler rtyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@rtyler rtyler enabled auto-merge October 11, 2024 12:49
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.42%. Comparing base (5b1ab37) to head (ae1eee1).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2934      +/-   ##
==========================================
- Coverage   72.43%   72.42%   -0.01%     
==========================================
  Files         131      131              
  Lines       40542    40542              
  Branches    40542    40542              
==========================================
- Hits        29366    29362       -4     
+ Misses       9291     9287       -4     
- Partials     1885     1893       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rtyler rtyler added this pull request to the merge queue Oct 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 11, 2024
@rtyler rtyler added this pull request to the merge queue Oct 11, 2024
Merged via the queue into delta-io:main with commit 7a3b03f Oct 11, 2024
24 checks passed
@0x26res 0x26res deleted the minor-fixes-to-the-doc branch October 14, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants