Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Mac Packaging #335

Closed
wants to merge 1 commit into from
Closed

Conversation

doadin
Copy link
Contributor

@doadin doadin commented Jan 9, 2022

Currently will produce a atrifact zip that contains similar structure to windows install.
If you extract that zip inside are binaries and those binaries run fine.

Currently trying to work out how to make a ".app".

@doadin doadin force-pushed the dev-mac branch 6 times, most recently from 64a72a7 to 3845cfd Compare January 9, 2022 11:39
@cas--
Copy link
Member

cas-- commented Jan 9, 2022

We already have a solution for creating an .app so let's not make using pyinstaller a priority since we don't have a stable Windows one yet

@doadin
Copy link
Contributor Author

doadin commented Jan 9, 2022

@cas-- Well, I figured out the issue and this build process works better than on windows so, idk. Up to you what you want. Its here if you want it or I can just close this. However its working now with little to no workarounds or anything like that. Other than some normal spec file things it just deletes requirments.txt from the dist. That other option is not merged and uses a different build system I think Its simpler to use pyinstaller for both, It can even use one single pyinstaller spec file if you want.(only seperate currently for testing)

@cas--
Copy link
Member

cas-- commented Jan 9, 2022

That's good to know, I just wanted to concentrate on one platform for now

@doadin doadin force-pushed the dev-mac branch 13 times, most recently from 5e69b18 to 38c590e Compare January 14, 2022 04:21
@doadin
Copy link
Contributor Author

doadin commented Jan 14, 2022

@cas-- I am going to go ahead and close this since I'm taking a break. Currently it builds and everything runs fine on 10.15 from the dist folder however the .app it makes I could not get to run not sure if its just user error or not I don't develop on mac very much so really not sure. I updated with some improvements learned from the windows builds. The only thing not working is the deluge exe is commented out even though it would run. The problem was it makes the .app fail to build I believe due to having the same name as the dist folder, If it was done on a case sensitive FS would probably be ok.

@doadin doadin closed this Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants