[GTKUI] Fix cairo crashes by not storing current context #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cas--
force-pushed
the
fix/cairo-crash-pieces
branch
from
0774938
to
439c039
Compare
Windows users have reported Deluge crashes when resizing the window with
Piecesbar or Stats plugins enabled:
Expression: CAIRO_REFERENCE_COUNT_HAS_REFERENCE(&surface->ref_count)
This is similar to issues fixed in GNU Radio which is a problem due to
storing the current cairo context which is then being destroyed and
recreated within GTK causing a reference count error
Fixes: https://dev.deluge-torrent.org/ticket/3339
Refs: gnuradio/gnuradio#6352
cas--
force-pushed
the
fix/cairo-crash-pieces
branch
from
439c039
to
af58996
Compare
Pillow have dropped 32-bit wheels from v10 onwards so force install of older v9 wheels since we don't want to build from src. Refs: python-pillow/Pillow#6941 (comment)
doadin
pushed a commit
to doadin/deluge
that referenced
this pull request
Jun 4, 2024
Windows users have reported Deluge crashes when resizing the window with
Piecesbar or Stats plugins enabled:
Expression: CAIRO_REFERENCE_COUNT_HAS_REFERENCE(&surface->ref_count)
This is similar to issues fixed in GNU Radio which is a problem due to
storing the current cairo context which is then being destroyed and
recreated within GTK causing a reference count error
Fixes: https://dev.deluge-torrent.org/ticket/3339
Refs: gnuradio/gnuradio#6352
Closes: deluge-torrent#431
doadin
pushed a commit
to doadin/deluge
that referenced
this pull request
Sep 21, 2024
Windows users have reported Deluge crashes when resizing the window with
Piecesbar or Stats plugins enabled:
Expression: CAIRO_REFERENCE_COUNT_HAS_REFERENCE(&surface->ref_count)
This is similar to issues fixed in GNU Radio which is a problem due to
storing the current cairo context which is then being destroyed and
recreated within GTK causing a reference count error
Fixes: https://dev.deluge-torrent.org/ticket/3339
Refs: gnuradio/gnuradio#6352
Closes: deluge-torrent#431
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows users have reported Deluge crashes when resizing the window with Piecesbar or Stats plugins enabled:
This is similar to issues fixed in GNU Radio which is a problem due to storing the current cairo context which is then being destroyed and recreated within GTK causing a reference count error
Fixes: https://dev.deluge-torrent.org/ticket/3339
Refs: gnuradio/gnuradio#6352