[Console] Fix 'move' command hanging when done #447
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhertz
force-pushed
the
console-move
branch
2 times, most recently
from
e99f334
to
bb08949
Compare
mhertz
force-pushed
the
console-move
branch
2 times, most recently
from
e1352ac
to
e533c5c
Compare
mhertz
changed the title
mhertz
force-pushed
the
console-move
branch
4 times, most recently
from
1913169
to
3924972
Compare
Console.get_torrent_name() expects string, but was given list from console.match_torrent(), so NoneType breaking join() in move message.
cas--
reviewed
Sep 9, 2024
|
You don't need to close this if you made a mistake, make the changes to your branch and force push it |
|
Appreciate you Cas. I used my phone for this, never done before, and got confused, sorry. I thought to try revert branch back and make change again, so single commit for you to merge, but as you kindly said can just change/force-push, then did that. I would have amend'ed the last commit, but that was the "sync fork" commit I pressed on phone(thought would be same as rebase in cli), after accepting review, so hence made new commit. Sorry about that. I will look into the linting error later, and change if can. Thanks! Edit: Done. |
mhertz
force-pushed
the
console-move
branch
from
d9f1073
to
8b9c283
Compare
Console.get_torrent_name() expects string, but was given list from console.match_torrent(), so NoneType breaking join() in move message. Simplified and fixed now. Co-authored-by: Calum Lind <[email protected]>
doadin
pushed a commit
to doadin/deluge
that referenced
this pull request
Sep 21, 2024
Console.get_torrent_name() expects string, but was given list from console.match_torrent(), so NoneType breaking join() in move message. Console.get_torrent_name() expects string, but was given list from console.match_torrent(), so NoneType breaking join() in move message. Simplified and fixed now. Co-authored-by: Calum Lind <[email protected]> Closes: deluge-torrent#447
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Console.get_torrent_name() expects string, but was given list from console.match_torrent(), so NoneType breaking join() in move message. Simplified and fixed now.