Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using pypechain and hyperdrivetypes events #1698

Merged
merged 18 commits into from
Oct 8, 2024

Conversation

slundqui
Copy link
Contributor

@slundqui slundqui commented Oct 7, 2024

This PR updates to use hyperdrivetypes v1.0.9.6.

Breaking changes:

  • Arguments from events are now wrapped in an args object. E.g., (open_long_event.maturity_time -> open_long_event.args.maturity_time).

Major changes:

  • Using hyperdrivetypes events instead of custom agent0 event types.
  • Removing log parsing in ethpy in favor of using pypechain event getters.
  • Removing conversion functions in favor of using conversion functions in hyperdrivetypes.
  • Moving event getters out of ethpy into chainsync, as most of these getters are specific for data management.

Minor changes:

  • Prefixing db schema classes with DB to avoid confusion with hyperdrivepy types.
  • Removing registry deployment and management in local hyperdrive deployment.

@slundqui slundqui marked this pull request as ready for review October 8, 2024 16:52
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 46 lines in your changes missing coverage. Please review.

Project coverage is 81.06%. Comparing base (9c5bd0e) to head (e46a39c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...rc/agent0/chainsync/db/hyperdrive/event_getters.py 77.50% 9 Missing ⚠️
src/agent0/chainsync/db/hyperdrive/interface.py 89.04% 8 Missing ⚠️
...ent0/ethpy/hyperdrive/interface/_contract_calls.py 87.87% 8 Missing ⚠️
...c/agent0/ethpy/hyperdrive/interface/_event_logs.py 20.00% 8 Missing ⚠️
...rfuzz/unit_fuzz/fuzz_long_short_maturity_values.py 50.00% 8 Missing ⚠️
...c/agent0/hyperfuzz/system_fuzz/invariant_checks.py 71.42% 2 Missing ⚠️
src/agent0/ethpy/hyperdrive/deploy.py 85.71% 1 Missing ⚠️
...gent0/ethpy/hyperdrive/interface/read_interface.py 88.88% 1 Missing ⚠️
...hyperfuzz/unit_fuzz/helpers/close_random_trades.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1698      +/-   ##
==========================================
- Coverage   81.47%   81.06%   -0.41%     
==========================================
  Files          99       98       -1     
  Lines        7643     7300     -343     
==========================================
- Hits         6227     5918     -309     
+ Misses       1416     1382      -34     
Flag Coverage Δ
unittests 81.06% <86.66%> (-0.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@slundqui slundqui merged commit ae56ff7 into delvtech:main Oct 8, 2024
5 checks passed
@slundqui slundqui deleted the pypechain-update branch October 8, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants