Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refork periodically #1711

Merged
merged 6 commits into from
Oct 22, 2024
Merged

Refork periodically #1711

merged 6 commits into from
Oct 22, 2024

Conversation

slundqui
Copy link
Contributor

@slundqui slundqui commented Oct 22, 2024

Minor fixes:

  • Bugfix to random policy to not attempt to remove liquidity if the amount of LP the wallet contains is less than the minimum transaction amount.
  • Bugfix for minimum transaction amounts in the case where agent0 is dealing with share amounts.
  • Adding rollbar ignores for fork fuzzing to avoid spamming rollbar.

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 75.75758% with 8 lines in your changes missing coverage. Please review.

Project coverage is 81.87%. Comparing base (a95e72e) to head (a9153d9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...gent0/ethpy/hyperdrive/interface/read_interface.py 57.14% 3 Missing ⚠️
src/agent0/core/hyperdrive/policies/random.py 88.88% 2 Missing ⚠️
...ent0/ethpy/hyperdrive/interface/_contract_calls.py 33.33% 2 Missing ⚠️
src/agent0/core/hyperdrive/policies/random_hold.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1711      +/-   ##
==========================================
- Coverage   82.09%   81.87%   -0.23%     
==========================================
  Files          93       93              
  Lines        6954     6974      +20     
==========================================
+ Hits         5709     5710       +1     
- Misses       1245     1264      +19     
Flag Coverage Δ
unittests 81.87% <75.75%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@slundqui slundqui merged commit 438a56c into main Oct 22, 2024
4 checks passed
@slundqui slundqui deleted the fork-fuzz-restart branch October 22, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants