Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix invariant check to not require stateful variables #1731

Merged
merged 13 commits into from
Nov 12, 2024

Conversation

dpaiton
Copy link
Member

@dpaiton dpaiton commented Nov 10, 2024

The negative interest check now directly looks up previous pool states instead of updating a stateful variable.

other fixes:

  • update hyperdrivetypes
  • rename interface.get_deploy_block() to interface.get_deploy_block_number() and change output type from int | None to BlockNumber | None
  • fix import bugs caused by latest pypechain update
  • rename block_before_timestamp.py to match function, block_number_before_timestamp
  • fix utils init file so that only functions are listed under imports

@dpaiton dpaiton marked this pull request as ready for review November 10, 2024 15:19
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 65.38462% with 9 lines in your changes missing coverage. Please review.

Project coverage is 80.96%. Comparing base (5cd827e) to head (7dc012d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...c/agent0/hyperfuzz/system_fuzz/invariant_checks.py 52.63% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1731      +/-   ##
==========================================
- Coverage   81.17%   80.96%   -0.21%     
==========================================
  Files          94       94              
  Lines        7092     7099       +7     
==========================================
- Hits         5757     5748       -9     
- Misses       1335     1351      +16     
Flag Coverage Δ
unittests 80.96% <65.38%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dpaiton dpaiton force-pushed the dpaiton/fix-invariance-fuzz branch 2 times, most recently from 8da575f to 0783b4a Compare November 12, 2024 00:26
@dpaiton dpaiton enabled auto-merge (squash) November 12, 2024 00:38
pyproject.toml Outdated Show resolved Hide resolved
@dpaiton dpaiton merged commit a75a091 into main Nov 12, 2024
4 checks passed
@dpaiton dpaiton deleted the dpaiton/fix-invariance-fuzz branch November 12, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants