-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix invariant check to not require stateful variables #1731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpaiton
force-pushed
the
dpaiton/fix-invariance-fuzz
branch
from
November 11, 2024 05:22
adea9ef
to
8adfe9f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1731 +/- ##
==========================================
- Coverage 81.17% 80.96% -0.21%
==========================================
Files 94 94
Lines 7092 7099 +7
==========================================
- Hits 5757 5748 -9
- Misses 1335 1351 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dpaiton
force-pushed
the
dpaiton/fix-invariance-fuzz
branch
2 times, most recently
from
November 12, 2024 00:26
8da575f
to
0783b4a
Compare
dpaiton
force-pushed
the
dpaiton/fix-invariance-fuzz
branch
from
November 12, 2024 00:29
0783b4a
to
20c6957
Compare
slundqui
approved these changes
Nov 12, 2024
slundqui
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The negative interest check now directly looks up previous pool states instead of updating a stateful variable.
other fixes:
interface.get_deploy_block()
tointerface.get_deploy_block_number()
and change output type fromint | None
toBlockNumber | None
block_before_timestamp.py
to match function,block_number_before_timestamp