Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update negative interest check to use relative tolerance for log level #1735

Merged
merged 6 commits into from
Nov 16, 2024

Conversation

dpaiton
Copy link
Member

@dpaiton dpaiton commented Nov 16, 2024

if above the absolute threshold, log an error.
if also above relative threshold, level is critical; else level is warning.

Copy link

codecov bot commented Nov 16, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.91%. Comparing base (464a21f) to head (94c1c53).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...c/agent0/hyperfuzz/system_fuzz/invariant_checks.py 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1735      +/-   ##
==========================================
- Coverage   81.10%   80.91%   -0.20%     
==========================================
  Files          96       96              
  Lines        7118     7120       +2     
==========================================
- Hits         5773     5761      -12     
- Misses       1345     1359      +14     
Flag Coverage Δ
unittests 80.91% <50.00%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dpaiton dpaiton enabled auto-merge (squash) November 16, 2024 06:52
@dpaiton dpaiton merged commit 401e2d9 into main Nov 16, 2024
4 checks passed
@dpaiton dpaiton deleted the dpaiton/negative-interest branch November 16, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants