Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in ReadProposal._getExecutedEvents #421

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Fix bug in ReadProposal._getExecutedEvents #421

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6411866
Fix
ryangoree Mar 21, 2024
921ffd2
Account for edge case where is
ryangoree Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions packages/council-core/src/models/proposal/ReadProposal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,12 +422,24 @@ export class ReadProposal extends Model {
protected async _getExecutedEvents(): Promise<
Event<typeof CoreVoting.abi, "ProposalExecuted">[]
> {
const lastCallBlock = await this.getLastCallBlock();
let toBlock = await this.getLastCallBlock();
const latestBlock = await this.network.getBlock();

// Ensure we don't try to fetch a block range including blocks that don't
// exist yet.
if (
typeof toBlock === "bigint" &&
typeof latestBlock?.blockNumber === "bigint" &&
latestBlock.blockNumber < toBlock
) {
toBlock = latestBlock.blockNumber;
}

const events = await this.coreVoting.contract.getEvents(
"ProposalExecuted",
{
fromBlock: this.created,
toBlock: lastCallBlock,
toBlock,
},
);

Expand Down