Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WalletConnect #434

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Fix WalletConnect #434

merged 1 commit into from
Jul 3, 2024

Conversation

ryangoree
Copy link
Member

@ryangoree ryangoree commented Jul 3, 2024

Destructuring assignment of environment variables doesn't work so the WalletConnect environment variable was undefined after #431. This fixes the check to ensure WalletConnect is visible when the environment variable is defined.

Copy link

changeset-bot bot commented Jul 3, 2024

⚠️ No Changeset found

Latest commit: e65d3df

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jul 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
council-kit-council-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2024 1:59pm
council-kit-landing-page ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2024 1:59pm

@ryangoree ryangoree merged commit f6c0dfd into main Jul 3, 2024
8 checks passed
@ryangoree ryangoree deleted the ryan-wallet-connect branch July 3, 2024 14:14
ryangoree added a commit to element-foundation/council-kit that referenced this pull request Jul 3, 2024
ryangoree added a commit to element-foundation/council-kit that referenced this pull request Jul 3, 2024
* Bump versions

* Add changesets

* chore: version packages (delvtech#425)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Fix WalletConnect (delvtech#434)

* Delete local packages in favor of NPM hosted versions

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant