Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(2/3) keeper-based rebalance + rebalance options #12

Merged
merged 16 commits into from
Oct 31, 2024
Merged

(2/3) keeper-based rebalance + rebalance options #12

merged 16 commits into from
Oct 31, 2024

Conversation

mcclurejt
Copy link
Contributor

Closes delvtech/hyperdrive#1202

  • Converts rebalance() to an external function that will be called by an admin
  • Introduces RebalanceOptions to configure rebalance behavior.
    • Can limit the amount of mature positions to close (avoids out-of-gas issues)
    • Can set slippage on openLong
    • Can set spending limit on openLong (avoids insufficient liquidity issues)

@mcclurejt mcclurejt changed the title keeper-based rebalance + rebalance options [WIP] keeper-based rebalance + rebalance options Oct 30, 2024
@mcclurejt mcclurejt marked this pull request as ready for review October 30, 2024 17:10
@mcclurejt mcclurejt changed the title [WIP] keeper-based rebalance + rebalance options keeper-based rebalance + rebalance options Oct 30, 2024
@mcclurejt mcclurejt changed the title keeper-based rebalance + rebalance options (2/3) keeper-based rebalance + rebalance options Oct 31, 2024
jalextowle
jalextowle reviewed Oct 31, 2024
View reviewed changes
contracts/Everlong.sol Outdated Show resolved Hide resolved
jalextowle
jalextowle reviewed Oct 31, 2024
View reviewed changes
contracts/Everlong.sol Outdated Show resolved Hide resolved
jalextowle
jalextowle reviewed Oct 31, 2024
View reviewed changes
Copy link
Contributor

@jalextowle jalextowle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the comments are addressed

contracts/Everlong.sol Outdated Show resolved Hide resolved
contracts/Everlong.sol Outdated Show resolved Hide resolved
contracts/Everlong.sol Outdated Show resolved Hide resolved
contracts/Everlong.sol Show resolved Hide resolved
contracts/Everlong.sol Outdated Show resolved Hide resolved
contracts/Everlong.sol Outdated Show resolved Hide resolved
contracts/interfaces/IEverlong.sol Outdated Show resolved Hide resolved
contracts/interfaces/IEverlongPortfolio.sol Outdated Show resolved Hide resolved
test/harnesses/EverlongTest.sol Show resolved Hide resolved
Base automatically changed from mcclurejt/feat/partial-closures-2 to main October 31, 2024 20:07
@mcclurejt mcclurejt force-pushed the mcclurejt/feat/hyperdrive-error-handling branch from e6502a6 to 11c43b9 Compare October 31, 2024 20:08
@mcclurejt
first stab at partial closures
c062145
@mcclurejt
introduce minimum remaining bonds threshold to avoid positions with v…
4d6b982 
…ery few bonds
@mcclurejt
fix
bc3b665
@mcclurejt
better partial estimation, fuzz tests, pricing edge case test
0a8c8d9
@mcclurejt
better comments, tighter tolerances
84af483
@mcclurejt
fixes to avoid underflow when trying to withdraw assets greater than …
321ec0b 
…everlong's _totalAssets
@mcclurejt
cleanup
80658ee
@mcclurejt
remove console
d9ed657
@mcclurejt
no need for mature position slippage guards
dbbbc0f
@mcclurejt
slippage guard docs and partial closure test adjustments
3761bb4
@mcclurejt
convert rebalance to only be called by an external keeper
f940f85 
Keepers are expected to use the configuration object to circumvent
hyperdrive errors
@mcclurejt
notes for future self
5c46a07
@mcclurejt
better commenting and devex
848117c
@mcclurejt
testing cleanup + make rebalance opt-in for depositEverlong and redee…
ad4d2d7 
…mEverlong
@mcclurejt mcclurejt force-pushed the mcclurejt/feat/hyperdrive-error-handling branch from 01d9185 to ad4d2d7 Compare October 31, 2024 21:17
@mcclurejt mcclurejt added this pull request to the merge queue Oct 31, 2024
Merged via the queue into main with commit cadf9be Oct 31, 2024
2 checks passed
@mcclurejt mcclurejt deleted the mcclurejt/feat/hyperdrive-error-handling branch October 31, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jalextowle jalextowle jalextowle approved these changes

@jrhea jrhea Awaiting requested review from jrhea jrhea is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Everlong Hyperdrive Error Handling + Limits Consideration
2 participants
@mcclurejt @jalextowle