Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] evaluate whether a constant vault share price is an appropriate invariant #13

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

[WIP] evaluate whether a constant vault share price is an appropriate invariant #13

wants to merge 9 commits into from

Commits on Nov 4, 2024

  1. first stab at partial closures

    @mcclurejt
    mcclurejt committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    5e447a2 View commit details
    Browse the repository at this point in the history

  2. introduce minimum remaining bonds threshold to avoid positions with v… 

    …ery few bonds
    @mcclurejt
    mcclurejt committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    8a7ccfb View commit details
    Browse the repository at this point in the history

  3. fix

    @mcclurejt
    mcclurejt committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    cea624b View commit details
    Browse the repository at this point in the history

  4. better partial estimation, fuzz tests, pricing edge case test

    @mcclurejt
    mcclurejt committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    75cf6d9 View commit details
    Browse the repository at this point in the history

  5. better comments, tighter tolerances

    @mcclurejt
    mcclurejt committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    e94d326 View commit details
    Browse the repository at this point in the history

  6. fixes to avoid underflow when trying to withdraw assets greater than … 

    …everlong's _totalAssets
    @mcclurejt
    mcclurejt committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    476902c View commit details
    Browse the repository at this point in the history

  7. convert rebalance to only be called by an external keeper 

    Keepers are expected to use the configuration object to circumvent
hyperdrive errors
    @mcclurejt
    mcclurejt committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    69d0dca View commit details
    Browse the repository at this point in the history

  8. better commenting and devex

    @mcclurejt
    mcclurejt committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    29bfa3d View commit details
    Browse the repository at this point in the history

  9. Evaluate whether a constant vault share price is an appropriate invar… 

    …iant

- Removed rebalancing from sandwich tests since the situation is
supposed to be atomic
- Keeping share price constant has the exact same effect as not
distributing losses.
  - This results in bad UX + a DOS vector for small position sizes.
  - In the case of bonds devaluing via huge LP, this loss should affect
others.
- No need to handle the case where a redemption would be zero, with
distributed losses this isn't possible.
- Vault share price decreases on deposit, remains constant on redemption
(for base atomic case).
    @mcclurejt
    mcclurejt committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    0bb6b9c View commit details
    Browse the repository at this point in the history