Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Very simple deposit/withdraw logic and share accounting #3

Merged
merged 27 commits into from
Aug 27, 2024
Merged

Very simple deposit/withdraw logic and share accounting #3

merged 27 commits into from
Aug 27, 2024

Conversation

mcclurejt
Copy link
Contributor

@mcclurejt mcclurejt commented Aug 7, 2024 •
edited
Loading

Adds simple deposit + redeem logic.

Adds simple share accounting where each depositor receives shares equal to their deposit amount and share price is pegged to 1. This will be updated by future pr's.

@mcclurejt mcclurejt marked this pull request as ready for review August 7, 2024 19:22
@mcclurejt mcclurejt changed the title [WIP] Very simple deposit/withdraw logic and share accounting Very simple deposit/withdraw logic and share accounting Aug 7, 2024
jalextowle
jalextowle reviewed Aug 15, 2024
View reviewed changes
contracts/Everlong.sol Outdated Show resolved Hide resolved
jalextowle
jalextowle approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@jalextowle jalextowle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the comments are addressed

@mcclurejt mcclurejt added this pull request to the merge queue Aug 27, 2024
Merged via the queue into main with commit 599067b Aug 27, 2024
3 checks passed
@mcclurejt mcclurejt deleted the mcclurejt/feat/deposit-withdraw branch August 27, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jalextowle jalextowle jalextowle approved these changes

@jrhea jrhea Awaiting requested review from jrhea jrhea is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Everlong Redeem + Unit Tests Everlong Deposit + Unit Tests
2 participants
@mcclurejt @jalextowle