Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vault share pricing and unmatured position valuation #4

Merged
merged 15 commits into from
Sep 9, 2024
Merged

vault share pricing and unmatured position valuation #4

merged 15 commits into from
Sep 9, 2024

Conversation

mcclurejt
Copy link
Contributor

@mcclurejt mcclurejt commented Sep 5, 2024 •
edited
Loading

fixes delvtech/hyperdrive#1089

This is rfr....

NOTE: The refactoring made some of the existing tests redundant/obsolete. Probably safe to ignore all unit/integration except for HyperdriveExecution.t.sol. Since this PR is already huge I'll be redoing those in another pr, and can combine the two before merging.

@mcclurejt mcclurejt changed the title [WIP] vault share pricing and unmatured position valuation vault share pricing and unmatured position valuation Sep 7, 2024
@mcclurejt mcclurejt marked this pull request as ready for review September 7, 2024 07:36
jalextowle
jalextowle reviewed Sep 7, 2024
View reviewed changes
contracts/Everlong.sol Outdated Show resolved Hide resolved
jalextowle
jalextowle reviewed Sep 7, 2024
View reviewed changes
contracts/Everlong.sol Outdated Show resolved Hide resolved
jalextowle
jalextowle reviewed Sep 7, 2024
View reviewed changes
contracts/Everlong.sol Outdated Show resolved Hide resolved
mcclurejt and others added 2 commits September 7, 2024 15:53
@mcclurejt @jalextowle
Update Everlong.sol
08e5290 
Co-authored-by: Alex Towle <[email protected]>
@mcclurejt @jalextowle
Update IEverlong.sol
8c1a6c9 
Co-authored-by: Alex Towle <[email protected]>
jalextowle
jalextowle reviewed Sep 7, 2024
View reviewed changes
contracts/Everlong.sol Outdated Show resolved Hide resolved
jalextowle
jalextowle reviewed Sep 7, 2024
View reviewed changes
Copy link
Contributor

@jalextowle jalextowle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good. I left some comments, but it looks good to me once those are addressed or acknowledged.

@mcclurejt
Copy link
Contributor Author

This is looking good. I left some comments, but it looks good to me once those are addressed or acknowledged.

going to fix test stuff, get review on that, then merge into this branch just fyi

@mcclurejt mcclurejt mentioned this pull request Sep 9, 2024
Merged
@mcclurejt @jalextowle
testing fixes (#5)
1dde190 
* tmp

* portfolio and 4626 fixes/tests

* fix rebase issues

* update existing tests, remove position tests (will re-add similar scope with idle liquidity feature)

* Update test/units/EverlongPortfolio.t.sol

Co-authored-by: Alex Towle <[email protected]>

* Update contracts/Everlong.sol

Co-authored-by: Alex Towle <[email protected]>

---------

Co-authored-by: Alex Towle <[email protected]>
@mcclurejt mcclurejt added this pull request to the merge queue Sep 9, 2024
Merged via the queue into main with commit 60ec1f1 Sep 9, 2024
3 checks passed
@mcclurejt mcclurejt deleted the mcclurejt/feat/vault-share-pricing branch September 9, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jalextowle jalextowle jalextowle approved these changes

@jrhea jrhea Awaiting requested review from jrhea jrhea is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Everlong Vault Share Price Mechanism + Unit Tests
2 participants
@mcclurejt @jalextowle