Add connection logging to help with debugging #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @kardianos, this is the second piece of #547 - a self-contained patch around adding in connection logging. |
|
Great to see it, but I want to wait until the first one is settled a bit more. |
wrosenuance
force-pushed
the
connection-logging
branch
from
86bf30a
to
768b5e3
Compare
Codecov Report
@@ Coverage Diff @@
## master #626 +/- ##
==========================================
- Coverage 71.98% 71.92% -0.06%
==========================================
Files 24 25 +1
Lines 5469 5529 +60
==========================================
+ Hits 3937 3977 +40
- Misses 1309 1322 +13
- Partials 223 230 +7
Continue to review full report at Codecov.
|
ninjadq
pushed a commit
to ninjadq/go-mssqldb
that referenced
this pull request
May 28, 2024
…dependency is dropped
ninjadq
pushed a commit
to ninjadq/go-mssqldb
that referenced
this pull request
May 28, 2024
fixes denisenkom#626: bump mysql driver version - appengine indirect dependency is dropped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging connection problems it can be helpful to look at the TDS traffic, ideally the unencrypted traffic if encryption is enabled. This patch adds a connection logger that emits the encrypted and unencrypted packets as a hex dump, and also supports the TLS_LOG_KEY_FILE needed for TLS interception in tools like Wireshark.
Split out of #547 where it was first used/relevant.