Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #446. Supplants #547 and uses azidentity to acquire tokens.
The basic shape of the change is the same as 547 - it creates a new
azuresql
driver which wraps the existing driver. The only changes required in core were to make the fedauth connector artifacts public.I am able to test it manually and with an ADO pipeline run in my organization but I don't know how to automate the E2E using the appveyor setup which is controlled by the project maintainers.
@kardianos please let me know if this satisfies your wishes for protecting the core.
@wrosenuance I think this keeps the spirit of your original change while updating the Azure components. I consulted with other SQL client driver owners to verify that all these authentication methods need to use the "ADAL" workflow.
The readme includes updated usage documentation.