Ignore spurious "rowcount" data from the server #735
+253
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First attempt at PR validation with gh action
Fix message ordering in Rowsq
Codecov Report
@@ Coverage Diff @@
## master #735 +/- ##
==========================================
- Coverage 71.29% 71.23% -0.07%
==========================================
Files 24 24
Lines 5386 5416 +30
==========================================
+ Hits 3840 3858 +18
- Misses 1301 1312 +11
- Partials 245 246 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQL sends rowcount status tokens in the
donemessage for statements likedeclare @d int = 1. The driver needs to keep track of whether columns have been sent or if the statement is not a select statement to determine if a real "rows affected" message should be sent.