Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-18170: benefit description fields minimum character limits #19598

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

jv-agile6
Copy link
Contributor

@jv-agile6 jv-agile6 commented Oct 23, 2024

Description

Relates to #18170

Screenshots

Screenshot 2024-10-23 at 4 12 25 PM Screenshot 2024-10-24 at 3 35 04 PM

QA steps

As an admin, log into tugboat

Navigate to VA Benefits Taxonomy

Edit a taxonomny term

What needs to be checked to prove this works?

Under Benefit Description check:

Teaser summary

  • Validate that min character is 20 and max is 300
  • Prevent form submission when user goes over character count or remains below minimum count: Yes

Brief summary

  • Validate that min character is 301 and is max 500
  • Min & max character count does not prevent submission

Longer summary

  • Validate that min character is 501 and max is unlimited
  • Min & max character count does not prevent submission

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 23, 2024 21:23 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 24, 2024 08:53 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 24, 2024 19:08 Destroyed
Copy link

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 24, 2024 19:17 Destroyed
Copy link

Checking composer.lock changes...

Copy link

The number of lines changed in composer.lock exceeds the acceptable threshold.

  • Lines changed: 4
  • Threshold: 200

This is a warning only. Please review the changes and ensure that they are acceptable.

Copy link

Checking composer.lock changes...

Copy link

The number of lines changed in composer.lock exceeds the acceptable threshold.

  • Lines changed: 4
  • Threshold: 200

This is a warning only. Please review the changes and ensure that they are acceptable.

@github-actions github-actions bot changed the title Vacms 18170 benefit description fields minimum character limits VACMS-18170: benefit description fields minimum character limits Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants