Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLR | Use focusOnAlertRole option for focus management #32703

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Mottie
Copy link
Contributor

@Mottie Mottie commented Oct 24, 2024

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

  • (Summarize the changes that have been made to the platform)

    Updating Higher-Level Review (HLR) form to focus on errors within web components (WC). Currently, the focus management is broken, but it should be focusing on the entire WC. This causes screen readers to read out the WC content instead of reading out the error message (using role="alert"). This is still experimental, but will be added to our appeals apps for further accessibility evaluation before making this behavior globally to all apps.

  • (If bug, how to reproduce)
  • (What is the solution, why is this the solution)
  • (Which team do you work for, does your team own the maintenance of this component?)

    Benefits Decision Reviews

  • (If using a flipper, what is the end date of the flipper being required/success criteria being targeted)

Related issue(s)

department-of-veterans-affairs/va.gov-team#93251

Testing done

  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected
  • Describe the tests completed and the results
  • _Exclusively stating 'Specs and automated tests passing' is NOT acceptable as appropriate testing
  • Optionally, provide a link to your test plan and test execution records

Screenshots

Before (broken focus management) After (focus on error inside web component)
Radio error focus no focus changes focus on error message & scroll to web component

What areas of the site does it impact?

HLR & HLR prototype

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@Mottie Mottie self-assigned this Oct 24, 2024
@Mottie Mottie requested review from a team as code owners October 24, 2024 14:21
@Mottie Mottie changed the title Use focusOnAlertRole formOptions in 996 HLR | Use focusOnAlertRole option for focus management Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants